fix: use tags instead of a custom invalid runtime option
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serverless 3 will throw an error if we use a `provider.runtime` option different from the allowed values. This PR removes the need to use the new runtime option (`rust`) and uses `tags.rust: true` inside the function configuration. This PR resolves softprops#107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Serverless 3 will throw an error if we use a
provider.runtimeoption different from the allowed values:This PR removes the need to use the new runtime option (
rust) and usestags.rust: trueinside the function configuration.Closes: #107
How did you verify your change:
Just put a
tag.rust: truein your function configuration and runnpx serverless package:What (if anything) would need to be called out in the CHANGELOG for the next release:
You can use the title of this PR.
@softprops =)